[OSCI][CI] set-output is deprecated #5340

vvavdiya · 2023-10-20T04:25:50Z

Description

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

Issues Resolved

#5322

Screenshot

Run cypress tests

https://github.com/vvavdiya/OpenSearch-Dashboards/actions/runs/6574727075/job/17864788175#logs

Testing the changes

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>

vvavdiya · 2023-10-20T04:35:01Z

@abbyhu2000
PR available for review. I have have replaced deprecated set-output as mentioned following guideline

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>

codecov · 2023-10-20T04:46:25Z

Codecov Report

Merging #5340 (e0b0f23) into main (e1db842) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5340   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        3286     3286           
  Lines       63148    63148           
  Branches    10054    10054           
=======================================
  Hits        42191    42191           
  Misses      18475    18475           
  Partials     2482     2482

Flag	Coverage Δ
Linux_1	`35.24% <ø> (ø)`
Linux_2	`55.25% <ø> (ø)`
Linux_3	`43.82% <ø> (ø)`
Linux_4	`35.34% <ø> (ø)`
Windows_1	`35.25% <ø> (ø)`
Windows_2	`55.22% <ø> (ø)`
Windows_3	`43.83% <ø> (ø)`
Windows_4	`35.34% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

joshuarrrr

Thanks @vvavdiya , looks good to me, although other maintainers are more familiar with GH workflows.

CHANGELOG.md

willie-hung · 2023-10-21T06:09:22Z

LGTM too!

…f deprecated `set-output` in workflows Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>

BigSamu

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:

Description
[CI] set-output is deprecated

Better would be

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

kavilla · 2023-10-23T21:26:59Z

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:

Description [CI] set-output is deprecated

Better would be

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

<3 Thank you a lot @BigSamu. A great call out as it is important because this project utilizes GitHub but not every fork of this repo utilizes GitHub. So each commit be able to communicate it's change to users of git. Related: https://forum.opensearch.org/t/missing-commit-messages-and-changelogs/6223.

Also, thank you so much @vvavdiya! A lot less warning messages now. I see the check link action still is outputting that warning. Did we want to update that as well or would you like to do it in a follow up PR? I'm fine with this as is but if it's quick enough would be better to get it in one go

vvavdiya · 2023-10-24T05:39:36Z

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:

Description [CI] set-output is deprecated

Better would be

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

Updated the descriptions with more explanation..

vvavdiya · 2023-10-24T05:43:55Z

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:
Description [CI] set-output is deprecated
Better would be
set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

<3 Thank you a lot @BigSamu. A great call out as it is important because this project utilizes GitHub but not every fork of this repo utilizes GitHub. So each commit be able to communicate it's change to users of git. Related: https://forum.opensearch.org/t/missing-commit-messages-and-changelogs/6223.

Also, thank you so much @vvavdiya! A lot less warning messages now. I see the check link action still is outputting that warning. Did we want to update that as well or would you like to do it in a follow up PR? I'm fine with this as is but if it's quick enough would be better to get it in one go

@kavilla Thanks for your review.
can you please help me with more details/context of the issue? so i can take it in follow up PR.

BigSamu

LGTM

CMDWillYang

LGTM as well!

kavilla · 2023-10-27T00:44:35Z

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:
Description [CI] set-output is deprecated
Better would be
set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

<3 Thank you a lot @BigSamu. A great call out as it is important because this project utilizes GitHub but not every fork of this repo utilizes GitHub. So each commit be able to communicate it's change to users of git. Related: https://forum.opensearch.org/t/missing-commit-messages-and-changelogs/6223.
Also, thank you so much @vvavdiya! A lot less warning messages now. I see the check link action still is outputting that warning. Did we want to update that as well or would you like to do it in a follow up PR? I'm fine with this as is but if it's quick enough would be better to get it in one go

@kavilla Thanks for your review. can you please help me with more details/context of the issue? so i can take it in follow up PR.

Oh I see, I think it is related to the actual github action we are using for checking links. The action might have an available upgrade that handles this deprecation.

But that's outside this issue.

Thank you!

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples Issues Resolved #5322 * replaced set-output * CI replaced set-output * Updated CHANGELOG.md for #5322 [CI] Replace usage of deprecated `set-output` in workflows Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 8d8de0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples Issues Resolved #5322 * replaced set-output * CI replaced set-output * Updated CHANGELOG.md for #5322 [CI] Replace usage of deprecated `set-output` in workflows Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 8d8de0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

vvavdiya added 2 commits October 19, 2023 18:09

replaced set-output

55d4fcb

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>

CI replaced set-output

346b477

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>

vvavdiya requested review from ananzh, kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy and curq as code owners October 20, 2023 04:25

github-actions bot added the first-time-contributor label Oct 20, 2023

vvavdiya changed the title ~~Ci replaced set output~~ [OSCI][CI] set-output is deprecated Oct 20, 2023

Updated CHANGELOG.md for change opensearch-project#5340

512e48d

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>

joshuarrrr previously approved these changes Oct 20, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

manasvinibs previously approved these changes Oct 20, 2023

View reviewed changes

Updated CHANGELOG.md for opensearch-project#5322 [CI] Replace usage o…

e0b0f23

…f deprecated `set-output` in workflows Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>

vvavdiya dismissed stale reviews from manasvinibs and joshuarrrr via e0b0f23 October 23, 2023 05:38

vvavdiya requested a review from joshuarrrr October 23, 2023 05:39

BigSamu reviewed Oct 23, 2023

View reviewed changes

manasvinibs approved these changes Oct 23, 2023

View reviewed changes

kavilla approved these changes Oct 23, 2023

View reviewed changes

kavilla added backport 2.x backport 2.11 ci OSCI Open Source Contributor Initiative labels Oct 23, 2023

kavilla linked an issue Oct 23, 2023 that may be closed by this pull request

[CI] set-output is deprecated #5322

Closed

vvavdiya requested review from kavilla and BigSamu October 24, 2023 05:44

BigSamu approved these changes Oct 24, 2023

View reviewed changes

CMDWillYang approved these changes Oct 24, 2023

View reviewed changes

kavilla approved these changes Oct 27, 2023

View reviewed changes

kavilla merged commit 8d8de0a into opensearch-project:main Oct 27, 2023
79 checks passed

kavilla removed the backport 2.11 label Oct 27, 2023

opensearch-trigger-bot bot mentioned this pull request Oct 27, 2023

[Backport 2.x] [OSCI][CI] set-output is deprecated #5380

Merged

opensearch-trigger-bot bot mentioned this pull request Oct 27, 2023

[Backport 2.11] [OSCI][CI] set-output is deprecated #5381

Closed

joshuarrrr added the v2.12.0 label Nov 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OSCI][CI] set-output is deprecated #5340

[OSCI][CI] set-output is deprecated #5340

vvavdiya commented Oct 20, 2023 •

edited

Loading

vvavdiya commented Oct 20, 2023

codecov bot commented Oct 20, 2023 •

edited

Loading

joshuarrrr left a comment

willie-hung commented Oct 21, 2023

BigSamu left a comment •

edited

Loading

kavilla commented Oct 23, 2023

vvavdiya commented Oct 24, 2023

vvavdiya commented Oct 24, 2023

BigSamu left a comment

CMDWillYang left a comment

kavilla commented Oct 27, 2023

[OSCI][CI] set-output is deprecated #5340

[OSCI][CI] set-output is deprecated #5340

Conversation

vvavdiya commented Oct 20, 2023 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Check List

vvavdiya commented Oct 20, 2023

codecov bot commented Oct 20, 2023 • edited Loading

Codecov Report

joshuarrrr left a comment

Choose a reason for hiding this comment

willie-hung commented Oct 21, 2023

BigSamu left a comment • edited Loading

Choose a reason for hiding this comment

kavilla commented Oct 23, 2023

vvavdiya commented Oct 24, 2023

vvavdiya commented Oct 24, 2023

BigSamu left a comment

Choose a reason for hiding this comment

CMDWillYang left a comment

Choose a reason for hiding this comment

kavilla commented Oct 27, 2023

vvavdiya commented Oct 20, 2023 •

edited

Loading

codecov bot commented Oct 20, 2023 •

edited

Loading

BigSamu left a comment •

edited

Loading